Fix Zerion collectibles count attribute #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorgomezv
changed the title
Pull Request Test Coverage Report for Build 8007163698Details
💛 - Coveralls |
iamacook
approved these changes
Feb 22, 2024
hectorgomezv
force-pushed
the
fix-zerion-count-attribute
branch
from
db26471
to
d997578
Compare
iamacook
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1192
Summary
This PR fixes the
countattribute for Zerion's collectibles retrieval. Since the Zerion API embraces an infinite scroll cursor strategy, it does not provide eithercountorprevious. Since the CGW was not allowingnullvalues forcount, before #1192 we couldn't use a property value for thecountattribute.Changes
countattribute tonullon Zerion's collectibles retrieval.